chore: enable TSL strictBooleanExpressions and sync sample rules - #1907
Merged
Conversation
- Enable TSL core rules in `.pkgs/configs/tsl.config.base.{js,ts}`
- `...core.all()`
- `core.strictBooleanExpressions` with explicit nullable handling
- Disable `noConfusingVoidExpression`, `preferOptionalChain`,
`switchExhaustivenessCheck`
- Update sample rule implementations in `.pkgs/samples/src` to satisfy
strict boolean expressions
- Replace truthy checks with explicit `!= null` / `== null`
- Remove decorative `// ─` section comments
- Sync updated sample code into migration guide MDX
(`apps/website/content/docs/migrating-from-eslint-plugin-react.mdx`)
- Update AST docs for `getCalleeName` description
- Tighten null checks in `packages/eslint/src/utils.ts` and
`packages/core/src/jsx.test.ts`
Rel1cx
marked this pull request as ready for review
July 15, 2026 13:16
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.pkgs/configs/tsl.config.base.{js,ts}...core.all()core.strictBooleanExpressionswith explicit nullable handlingnoConfusingVoidExpression,preferOptionalChain,switchExhaustivenessCheck.pkgs/samples/srcto satisfy strict boolean expressions!= null/== null// ─section commentsapps/website/content/docs/migrating-from-eslint-plugin-react.mdx)getCalleeNamedescriptionpackages/eslint/src/utils.tsandpackages/core/src/jsx.test.tsUpdate "[ ]" to "[x]" to check a box
What kind of change does this PR introduce?
Check at least one. If you are introducing a new binding, you must reference an issue where this binding has been proposed, discussed and approved by the maintainers.
Does this PR introduce a breaking change?
If yes, please describe the impact and migration path for existing applications in an attached issue.
Checklist
fix: remove a typo, closes #___, #___)Other information